search

beberlei / metrics

Simple library that abstracts different metrics collectors. I find this necessary to have a consistent and simple metrics (functional) API that doesn't cause vendor lock-in.
316 stars 38 forks source link

Add Redis adapter #37

Open vamsiikrishna opened 9 years ago

lyrixx commented 9 years ago

First thanks for your contribution.

As there is many redis adapater in the wild (predis credis, php_redis), could you rename the Redis class to CRedis ?

vamsiikrishna commented 9 years ago

@lyrixx I had similar idea, but I don't think creating a new class for every redis adapter will be practical . any other approach you can recommend ?

Thanks

lyrixx commented 9 years ago

I don't see any others.

vamsiikrishna commented 9 years ago

@lyrixx ok, will rename redis class to CRedis for now.

I will keep searching for any other ways. btw all redis libraries just need host and port to initiate the connection, that's why I asked if there is a better way.

Thanks

vamsiikrishna commented 9 years ago

Hi @lyrixx I have made necessary change . Please review

Thanks

lyrixx commented 9 years ago

@vamsiikrishna Do you have time to finish your PR ?

vamsiikrishna commented 9 years ago

@lyrixx I will try to complete this during weekend .

Regards

vamsiikrishna commented 8 years ago

@lyrixx @stof I have added support for sf bundle and have tried to implement the changes you guys have suggested. Please review .

Thanks

vamsiikrishna commented 8 years ago

Hi @lyrixx ,

any chance you can review it again ? thanks

lyrixx commented 8 years ago

@vamsiikrishna sure. But there is still pending comment that should be addressed. After that, we will be OK ;)

vamsiikrishna commented 8 years ago

@beberlei sorry to bother you again I had done the necessary changes , but I do have some doubts about the way I have implemented the bundle. can you please check this ?