Minor code improvements

beberlei / metrics

Simple library that abstracts different metrics collectors. I find this necessary to have a consistent and simple metrics (functional) API that doesn't cause vendor lock-in.

316 stars 38 forks source link

Minor code improvements #42

Closed eexit closed 9 years ago

eexit commented 9 years ago

[x] Use single quotes when possible
[x] Improve readability of string constructs
[ ] ~~Flags Graphite::push() as deprecated (shouldn't be part of the public interface)~~

eexit commented 9 years ago

PR updated.

lyrixx commented 9 years ago

Thank you Joris.

eexit commented 9 years ago

@lyrixx Could you make a new release with the changes please?

Thanks!

lyrixx commented 9 years ago

@eexit sure ;)

lyrixx commented 9 years ago

@eexit here we go: https://github.com/beberlei/metrics/releases/tag/v2.0.2

eexit commented 9 years ago

@lyrixx Thanks man! :)