Symfony 4 compat, require 3.3 or higher

nicoschoenmaker commented 6 years ago

Fixes #58.

Currently the (Symfony) class DefinitionDecorator is used, which has been renamed to ChildDefinition.

Problem at hand: this new class was only introduced in Symfony 3.3.

This is the most clean, but also a bit of an aggressive solution to this problem: require Symfony 3.3 (or 4.0).

Use ChildDefinition over DefinitionDecorator
Symfony 4 makes services private by default, so had to make some of them public in unit-tests.
Was forced to use PHPUnit\Framework\TestCase over \PHPUnit_Framework_TestCase, since otherwise I was unable to install the later Symfony versions. This makes it compatible with PHPUnit 6, which is nice.
Dropped php 5.4 and 5.5 support since Symfony 3 requires php >= 5.5 and PHPUnit does not include the namespaced TestCase class. Also they did not receive security updates >6 months by now.
Dropped hhvm from the travis build since phpunit does not support hhvm: https://github.com/sebastianbergmann/phpunit/issues/2581

An alternative, less aggressive PR can be found at #60.

lyrixx commented 6 years ago

:+1:

lyrixx commented 6 years ago

Hello. Could you rebase this PR? Thanks

nicoschoenmaker commented 6 years ago

Rebased :slightly_smiling_face:

lyrixx commented 6 years ago

Thanks you for your time ;)

beberlei / metrics