search

beberlei / metrics

Simple library that abstracts different metrics collectors. I find this necessary to have a consistent and simple metrics (functional) API that doesn't cause vendor lock-in.
316 stars 38 forks source link

Introducing: InlineTaggableGaugeableNullCollector #62

Closed jandeschuttere closed 4 years ago

jandeschuttere commented 6 years ago

For those who want the benefit of tags on metrics and still have typed support

jandeschuttere commented 6 years ago

thanks @becoded for a couple of small, yet important, remarks.

jandeschuttere commented 6 years ago

Hi @lyrixx,

I hope you are one of the main maintainers of this repository, If not apologies 🙇 , I just wanted to catch your attention and hope this can be merged. Any feedback in case you aren't agreeing with this PR is welcome.

Cheers

becoded commented 6 years ago

@lyrixx what needs to happen to get this merged in?

becoded commented 5 years ago

@lyrixx any news on this?

jandeschuttere commented 4 years ago

@lyrixx can we get this merged?

lyrixx commented 4 years ago

@jandeschuttere Thansk for your first PR. And I'm sorry for this delay