Split InfluxDB collector into two (leave current intact and introduce a separate one for official influxdb integration)

beberlei / metrics

Simple library that abstracts different metrics collectors. I find this necessary to have a consistent and simple metrics (functional) API that doesn't cause vendor lock-in.

316 stars 38 forks source link

Split InfluxDB collector into two (leave current intact and introduce a separate one for official influxdb integration) #72

Open andrejbaran opened 5 years ago

andrejbaran commented 5 years ago

Hey @lyrixx

here is an attempt to separate current InfluxDB integration and a new one using official package. This, if accepted, should replace #68 .

Unfortunately both packages use the same namespace InfluxDB so the new one isn't covered by tests. Any advice how to handle it correctly?

andrejbaran commented 5 years ago

@lyrixx Thanks for the quick review! ready for round 2

s7anley commented 5 years ago

Heya @lyrixx any chance we could land this into master?