search

beberlei / metrics

Simple library that abstracts different metrics collectors. I find this necessary to have a consistent and simple metrics (functional) API that doesn't cause vendor lock-in.
316 stars 38 forks source link

Graphite + cleaning #9

Closed lyrixx closed 9 years ago

lyrixx commented 11 years ago

Hello.

I added a graphite collector, and I also cleaned the library and fix some typo. I did lot of atomic commit.

lyrixx commented 11 years ago

@beberlei Is it ok for you ?

beberlei commented 11 years ago

Therse are so many different changes that are not related, i havent had time to evaluate if none of them breaks BC. Why didnt you create multiple PRs for this? Most of the changes seem cosmetical, but I can't be sure

lyrixx commented 11 years ago

I started to split this PR is smaller PRs. I am waiting for a review of the first PR. I will send more PRs after the first set ;)

Can you not close this PR until you merge/close other PRs ? thanks