search

bebnev / react-native-user-agent

Library that helps you to get mobile application user agent and web view user agent strings
MIT License
42 stars 42 forks source link

gradle build updates #13

Closed hagmic closed 2 years ago

hagmic commented 4 years ago

Closes #12

markrickert commented 4 years ago

I was having build Issues after upgrading from react-native 0.56.x to 0.61.5 and this PR was the last piece of the puzzle to get android compiling properly.

Without this fix, i was getting this error while trying to create an android build (building straight to device worked just fine):

> Task :react-native-user-agent:verifyReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-user-agent:verifyReleaseResources'.
> 1 exception was raised by workers:
  com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
  /Users/user/Documents/my-app/node_modules/react-native-user-agent/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
  /Users/user/Documents/my-app/node_modules/react-native-user-agent/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
  /Users/user/Documents/my-app/node_modules/react-native-user-agent/android/build/intermediates/res/merged/release/values/values.xml:2743: error: resource android:attr/fontVariationSettings not found.
  /Users/user/Documents/my-app/node_modules/react-native-user-agent/android/build/intermediates/res/merged/release/values/values.xml:2744: error: resource android:attr/ttcIndex not found.
  error: failed linking references.
jasonbodily commented 4 years ago

Same boat here. Recommending a merge and release :)

Gbr22 commented 4 years ago

Same issue here, the PR fixed it, would appreciate the merge

stephichau commented 3 years ago

@bebnev any updates on this? 🚀

pke commented 2 years ago

Please @bebnev add someone with merge rights to get this PR merged if you can't spare your own time. It would be sad to see this project go out of date.

bebnev commented 2 years ago

Sorry guys, was out for a while. Have a look at version 2.3.1

I fixed all the issues