search

bebop / poly

A Go package for engineering organisms.
https://pkg.go.dev/github.com/bebop/poly
MIT License
666 stars 70 forks source link

GbkLocationString should be in "Feature" not "Location #261

Closed Koeng101 closed 1 year ago

Koeng101 commented 2 years ago

When developing, it makes more sense for GbkLocationString to be a feature attribute, since location is entirely derived from it.

rkrishnasanka commented 1 year ago

I think it might be fine to leave it there; intuitively, if I'd want to find the Gbk source for the location, I'd look at the location object. Otherwise, it would need to be extra work to keep a map of location strings and the corresponding Location objects.

carreter commented 1 year ago

Bumping this stale issue - is this still applicable? Do we still want to do it?

Koeng101 commented 1 year ago

Hmmm, I think @rkrishnasanka is right. I'm going to close for now.