bebop / poly

A Go package for engineering organisms.
https://pkg.go.dev/github.com/bebop/poly
MIT License
663 stars 70 forks source link

Common Genbank `Feature.Type` values should be enumerated #351

Open carreter opened 11 months ago

carreter commented 11 months ago

While reviewing @cachemoi 's #350 , I noticed they added an explicit check for the type of a genbank Feature when determining whether the given feature was a coding sequence (feature.Type == "CDS").

Perhaps it would be helpful to encode common feature types into an enum (type FeatureType string) in the genbank package.

Blocked by #339 .

EDIT: another test

carreter commented 11 months ago

Testing to see if the new "blocked by" between issues works:

Blocked by #339 .

github-actions[bot] commented 11 months ago

Status: Ready to merge :heavy_check_mark:

Issues blocking this PR:

github-actions[bot] commented 8 months ago

This issue has had no activity in the past 2 months. Marking as stale.

github-actions[bot] commented 6 months ago

This issue has had no activity in the past 2 months. Marking as stale.