bebop / poly

A Go package for engineering organisms.
https://pkg.go.dev/github.com/bebop/poly
MIT License
659 stars 68 forks source link

fixed bug that produced wrong overhang in linear, non-directional, single cut reactions. #408

Closed TimothyStiles closed 7 months ago

TimothyStiles commented 7 months ago

Changes in this PR

fixed bug that produced wrong overhangs in linear, non-directional, single cut reactions.

Why are you making these changes?

There was a bug in CutWithEnzyme where in the case of linear, non-directional, single cut reactions, it would assume that the overhangs were produced by a forward facing cut site and return a sequence downstream. In the case of the cut being a reverse cut site it would return the wrong overhangs. This was fixed with a simple if-else

Are any changes breaking? (IMPORTANT)

There are no breaking changes.

Pre-merge checklist

All of these must be satisfied before this PR is considered ready for merging. Mergeable PRs will be prioritized for review.

Koeng101 commented 7 months ago

@TimothyStiles Why did you nuke the changelog in d0f6ab3?