search

bebraw / bunit.js

Simple testing lib for JS (MIT)
MIT License
7 stars 2 forks source link

Fixes IE issue when setUp function not defined in tests #1

Closed rdawe closed 11 years ago

rdawe commented 11 years ago

I've been trying out bunit, and it's been great so far. However, I found an issue with IE 8 that this pull request addresses. The issue is as follows:

  1. Set up bunit with a single test case
  2. Do not define a setUp function in the test case
  3. Run the tests in IE 8

Expected: test case runs, reporting success/fail Actual: IE reports "TypeError: Object expected"

This works fine in firefox and chrome. The issue appears to be IE not handling a missing return value.

bebraw commented 11 years ago

Awesome. Looks good. Merged. :)

Do you think it would be worth the effort to port suite.js to browser? It would be fairly easy to do I think. I like the syntax more and use that solely these days. It's missing some features (nice reporting etc.) but I really like it otherwise.

rdawe commented 11 years ago

Wow, thanks for the quick response!

I haven't looked at suite.js too much just yet; I've only been playing around with bunit for the past couple of hours. I'll look at it and let you know (it'll probably be early next week)

Thanks, ~ryan

On Fri, Nov 2, 2012 at 2:32 PM, Juho Vepsäläinen notifications@github.comwrote:

Awesome. Looks good. Merged. :)

Do you think it would be worth the effort to port suite.jshttps://github.com/bebraw/suite.jsto browser? It would be fairly easy to do I think. I like the syntax more and use that solely these days. It's missing some features (nice reporting etc.) but I really like it otherwise.

— Reply to this email directly or view it on GitHubhttps://github.com/bebraw/bunit.js/pull/1#issuecomment-10024532.

bebraw commented 11 years ago

Great. Take your time. :)