search

bebraw / bunit.js

Simple testing lib for JS (MIT)
MIT License
7 stars 2 forks source link

Latest RequireJS gives error: require.ready is not a function #4

Closed fuhrmanator closed 3 years ago

fuhrmanator commented 5 years ago

The call to require.ready seems to be deprecated in the latest versions of RequireJS. The fix is to use domReady per https://requirejs.org/docs/api.html#pageload.

bebraw commented 5 years ago

@fuhrmanator I noticed you did the fix. Do you want to send a PR? I don't mind merging. 👍

bebraw commented 5 years ago

@fuhrmanator Is there some specific case where you are using the library btw? I have moved to Jest and such a long time ago. I don't mind giving it over to you in case you want to push it further. 😄

fuhrmanator commented 5 years ago

Not really, I guess I didn't know about Jest :-/

bebraw commented 5 years ago

@fuhrmanator Ah, ok. I guess this project still might have use in some environment. It was more like a proof of concept for me back in the day. Feel free to throw me that PR and I'll merge. 👍