Callback "done" does not get triggered when using rgb

bebraw / colorjoe

Scaleable color picker with touch and AMD support (MIT)

http://bebraw.github.io/colorjoe/

MIT License

568 stars 68 forks source link

Callback "done" does not get triggered when using rgb #16

Closed edmundask closed 11 years ago

edmundask commented 11 years ago

I was doing something like this:

@colorPicker = colorjoe.rgb "color-picker", [....], [...]

@colorPicker.on "done", (color) ->
  ...

But then I realized that this does not work and throws an error. I dug a bit in the source code and noticed that it needed a minor fix. Not sure if this works in all cases, so I'll let you be the judge of that. Hope this helps.

bebraw commented 11 years ago

Thanks a lot!

I merged your pull request. I also need to do some maintenance on the project (need to update Grunt at least). After I'm done, I'll push a new version.

bebraw commented 11 years ago

Ok, done. There's a new version (0.8.1) available now. It comes with your fix, newer libs and updated Grunt configuration.

edmundask commented 11 years ago

Nice, cheers! :+1: