search

bebraw / colorjoe

Scaleable color picker with touch and AMD support (MIT)
http://bebraw.github.io/colorjoe/
MIT License
568 stars 68 forks source link

Hex et RGB color #33

Open simetin opened 8 years ago

simetin commented 8 years ago

Hi ! I got 2 problems when I try to manually enter a color. First, in the RGB field my cursor keep coming back to the end, I need to remplace it 2 times to be able to enter a color. Second, in the Hex field when I enter the color there is a modification in the hex value and when I press close, it change to black. Am I the only one with these problems ?

Your color picker is really great, so if I could get those two things to work, everything would be perfect !

Thanks !

bebraw commented 8 years ago

Can you try modifying hex extra? Here's rgb. Maybe there's some corner case missing.

simetin commented 8 years ago

I can try to take a look, but I really don't think that I'm skilled enough for that

bebraw commented 8 years ago

@tchinou1 Any luck? Do you want me to have a look? If you can set up a standalone test case for me to study, that will help.

simetin commented 8 years ago

No I haven't been able to do anything. If you want to check, it would be very nice ! But I'm not sure to understand what you mean by a standalone test case. Thanks !

bebraw commented 8 years ago

@tchinou1 Just something to illustrate the issue. Do you see it at the online demo?

simetin commented 8 years ago

No, here is a page of my app: http://luxontower.com/app/colorpickerdemo.php

bebraw commented 8 years ago

I got 2 problems when I try to manually enter a color. First, in the RGB field my cursor keep coming back to the end, I need to remplace it 2 times to be able to enter a color.

Confirmed. I think the hex input will need a little tweak to retain its position. It's going to get a little complicated depending on which browsers we want to support. Here's the basic idea: https://stackoverflow.com/questions/2897155/get-cursor-position-in-characters-within-a-text-input-field .

Second, in the Hex field when I enter the color there is a modification in the hex value and when I press close, it change to black.

This is a weird one. I cannot see the behavior in the official demo. Can you try to figure out how your setup differs from that? It looks like the value cycles (00000b -> 0000b0).

bebraw commented 8 years ago

Third issue: Before opening the selector, we should probably do a cropping check against the window. I mean we should open at top of the input if it's going to crop. Otherwise it's going to be unusable for those lower inputs.