search

bebraw / colorjoe

Scaleable color picker with touch and AMD support (MIT)
http://bebraw.github.io/colorjoe/
MIT License
568 stars 68 forks source link

Renamed onecolor to ONECOLOR but not everywhere #42

Closed thisispaul closed 6 years ago

thisispaul commented 6 years ago

In the 3.0.0 release you have renamed the onecolor variable to ONECOLOR but not when it is injected into the dist package so it is broken.

thisispaul commented 6 years ago

The main issue is that it seems in the src/colourjoe.js file all the calls to onecolor() have been renamed to ONECOLOR() for reasons I don't know why but the grunt build is still injecting the onecolor variable lowercase.

bebraw commented 6 years ago

Yeah, easy fix by the looks of it. Just testing and pushing. For some reason onecolor changed their scheme. Thanks for noticing.

bebraw commented 6 years ago

There's a preliminary fix now. Give it a go.

What do you think if I dropped the entire build step entirely? The trend is a little different now.

thisispaul commented 6 years ago

Yeah works now cheers!

What do you mean by dropping the build step completely?

Edit: I've never really published anything properly like this but I know you can hook into the prepublish npm and build libs that way so the node_module just includes a lib for easy import/requiring but not sure how that works with also publishing prepackaged dist stuff.

bebraw commented 6 years ago

@thisispaul The point would be to point directly to the source and skip bundling. I think I'll leave it as is for now, though, as there's no pressure to change.

thisispaul commented 6 years ago

@bebraw yeah its probably best to leave as is right now.