search

bebraw / colorjoe

Scaleable color picker with touch and AMD support (MIT)
http://bebraw.github.io/colorjoe/
MIT License
569 stars 68 forks source link

Added non-passive event listener to a scroll-blocking 'touchstart' event #45

Closed ffMathy closed 6 years ago

ffMathy commented 6 years ago

In Chrome, you get the following warning when using the library:

[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

When adding the touchmove event, we need to explicitly specify { passive: false } to fix this warning.

bebraw commented 6 years ago

Can you PR a fix? Thanks. 👍