Open rsbivand opened 3 years ago
katrina-slm.R
and katrina-slm-neigh.R
run OK, it's just katrina-slm-impacts.R
that doesn't complete.
Are you using the ‘update' branch? This is the one that is going to replace the current files on master.
El 4 feb 2021, a las 10:38, Roger Bivand notifications@github.com<mailto:notifications@github.com> escribió:
katrina-slm.R and katrina-slm-neigh.R run OK, it's just katrina-slm-impacts.R that doesn't complete.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/becarioprecario/slm/issues/3#issuecomment-773170667, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABYD6WVMGN5OUPTM2OTIVHLS5JTKNANCNFSM4XCPLEIA.
No, I usually ignore branches and never use them. I always assume that branches were just for local work, and are on the central repo for reference only. I've been working only in the main branch of my fork - how should I merge your update with my fork main, or update my fork of your update to my main and your update ????
I'm trying to merge manually locally. Do not use your update branch, I will make a PR against your main branch.
I'm trying to merge manually locally. Do not use your update branch, I will make a PR against your main branch.
Thanks. I removed all the code related to the approximation that we had in the first version of the paper. I could try to make the merge if you are unsure about what to keep/remove.
I'm some way through. For boston, the use of eigenvalues assumes that n is small enough, but for house, the new impacts approach is not feasible. I'll PR to main branch only when completed, forget any other branches. I have no sarp.RData, will try to reconstruct from the spatialprobit package.
OK. Thanks for checking this.
I'm some way through. For boston, the use of eigenvalues assumes that n is small enough, but for house, the new impacts approach is not feasible. I'll PR to main branch only when completed, forget any other branches. I have no sarp.RData, will try to reconstruct from the spatialprobit package.
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/becarioprecario/slm/issues/3#issuecomment-773340150, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABYD6WSLWOJV2EKCVYVO62DS5KUFVANCNFSM4XCPLEIA.
Did something change in the internals?