search

beckenrode / mysql-workbench-export-laravel-5-migrations

A MySQL Workbench plugin which exports a Model to Laravel 5 Migrations
MIT License
898 stars 236 forks source link

Bugfix - VARCHAR MySQL field as primary key #68

Closed alexandrufulop closed 3 years ago

alexandrufulop commented 4 years ago

THANK YOU to @beckenrode and all the other contributors to this project!

My pull request addresses an issue regarding the primary key as a VARCHAR. Please check the changelog for more info.

VeeeneX commented 4 years ago

@alexandrufulop Thank you for your contribution, it's good idea to make a change log, but I'm not sure about @beckenrode opinion but I'd use https://keepachangelog.com/en/1.0.0/, since it's a standard, anyway, the commit looks good. I'll have a further look and let you know then :)

alexandrufulop commented 4 years ago

Thanks!

On Tue, 1 Oct 2019, 22:53 VeeeneX, notifications@github.com wrote:

@alexandrufulop https://github.com/alexandrufulop Thank you for your contribution, it's good idea to make a change log, but I'm not sure about @beckenrode https://github.com/beckenrode opinion but I'd use https://keepachangelog.com/en/1.0.0/, since it's a standard, anyway, the commit looks good. I'll have a further look and let you know then :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/beckenrode/mysql-workbench-export-laravel-5-migrations/pull/68?email_source=notifications&email_token=AAEP2JZ3CH4HM6WGDCJT6VDQMOTEXA5CNFSM4I4FXLWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEACQWLA#issuecomment-537201452, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEP2J2WYMWK6G5OK4WHGOTQMOTEXANCNFSM4I4FXLWA .