search

beckerbenj / eatRecode

https://beckerbenj.github.io/eatRecode/
GNU General Public License v3.0
0 stars 2 forks source link

assert newValues column name, closes #20 #21

Closed nickhaf closed 10 months ago

nickhaf commented 10 months ago

removed newCol argument from useRecodeList(). (sorry for the commit mess, commited to main by accident and reverted so i could get your feedback)

nickhaf commented 10 months ago

@beckerbenj : Just changed it, however i had the feeling it made the following workflow (extracting ManualRecodes, updating the data base) more cumbersome, as you always have to define the varName and new_varName arguments, so the functions now with which columns to work with. This in mind, I think it made more sense to define the column names in the beginning, so it's less for the user to think about. But let me know what you think, maybe there is some way to have both?

beckerbenj commented 10 months ago

Ahh, I see, thanks for pointing that out! Should we discuss this via phone/zoom?

nickhaf commented 10 months ago

We talked about this and concluded that the function should stay as flexible as possible. This pull request can therefore be closed without merging, however we will have to deal with #20