beckn / DSEP-Specification

Open Interoperable Specifications for Skilling and Education. An adaptation of Beckn Protocol.
Other
18 stars 21 forks source link

on_search example response is not beckn protocol compliant #130

Closed ravi-prakash-v closed 10 months ago

ravi-prakash-v commented 1 year ago

In the following example,

https://github.com/beckn/DSEP-Specification/blob/master/artefacts/beckn%20specifications/jobs-internships/search/search%20request%20-%20only%20provider%20location.json

The on_search callback has the following template

{
    "context": {
        ...
    },
    "responses": [
        {
            "context": {
                ...
            }
        }
    ]
}

which is non compliant to beckn protocol message packet structure.

The correct response should be


{
    "context": {
        ...
    },
    "message": {
        "catalog": {
            ...
        }
    }
}
``

Please refer to the schema in https://github.com/beckn/protocol-specifications/blob/master/api/transaction/components/io/OnSearch.yaml
emmayank commented 10 months ago

Hi @ravi-prakash-v ,

I’m pleased to inform you that the issue you reported has been successfully resolved and incorporated into the latest changes. The corresponding pull request has been merged with the draft branch.

Details:

If you have any further questions or concerns, feel free to reach out. We appreciate your contribution and diligence in bringing this to our attention!

Best regards, emmayank