beckn / DSEP-Specification

Open Interoperable Specifications for Skilling and Education. An adaptation of Beckn Protocol.
Other
19 stars 21 forks source link

Some on_action example response is not as per beckn protocol compliant #153

Closed emmayank closed 10 months ago

emmayank commented 1 year ago

In the following example,

Expert connect

  1. on_cancel
  2. on_confirm
  3. on_init
  4. on_search
  5. on_select
  6. on_status
  7. on_update

Job

  1. on_cancel
  2. on_confirm
  3. on_select
  4. on_status
  5. on_update

The on_action callback has the following template

{
    "context": {
        ...
    },
    "responses": [
        {
            "context": {
                ...
            }
        }
    ]
}

which is non compliant to beckn protocol message packet structure.

The correct response should be

{
    "context": {
        ...
    },
    "message": {
        {
            ...
        }
    }
}
emmayank commented 10 months ago

Closing this issue, as it is resolved in this pull request - https://github.com/beckn/DSEP-Specification/pull/163