beckn / DSEP-Specification

Open Interoperable Specifications for Skilling and Education. An adaptation of Beckn Protocol.
Other
19 stars 21 forks source link

Specification Misalignment: Discrepancies Between the DSEP spec and the referenced Core Spec #164

Open rajaneeshk90 opened 10 months ago

rajaneeshk90 commented 10 months ago

Issue Details:

Problem Statement: The DSEP specification outlined in the /api folder(link to the DSEP specification definition) references the core spec version 1.1.0, but discrepancies exist in their adherence to the referenced core spec. The discrepancies are listed below.

1. The structure of the DSEP specification deviates from the Beckn core specification in the handling of location information. For instance:

In the Beckn core protocol specification context, the location object encapsulates both city and country:

"location": {
    "city": {
        "name": "Bangalore",
        "code": "std:080"
    },
    "country": {
        "name": "India",
        "code": "IND"
    }
}

However, the DSEP specification does not include a location object within context. Instead, city and country are directly placed inside context:

"country": "IND",
"city": "std:080"

2. The examples that are used in the specification yaml (dsep-v0.7.yaml) are not as per the core-v1.1 specification. Link 3. Unused components are present in the specification yaml. For example, Policy, StructuredAddress, FullAddress, FeedbackUrl, FeedbackFormElement, FeedbackForm & Feedback schema is defined in the dsep-v0.7.yaml but are not used. 4. Rating & on_rating specs is not as per core-v1.1.yaml Link

It is essential to investigate these inconsistencies and rectify the misalignment between the DSEP specification and the referenced Beckn core protocol specification.

nirmalnr commented 9 months ago

The PR still has an old version of xInput. Described the same in the comment here: https://github.com/beckn/DSEP-Specification/pull/171#issuecomment-1945993200