search

beckn / DSEP-Specification

Open Interoperable Specifications for Skilling and Education. An adaptation of Beckn Protocol.
Other
18 stars 21 forks source link

Validated DSEP Specification with Core v 1.1.0 #175

Open emmayank opened 5 months ago

emmayank commented 5 months ago

Description

Validated the dsep.yaml file with the core-spec v1.1.0 version. Also, validated the examples JSON files given in the example directory and in the implementation guide against core-spec v1.1.0.

Task Completed

  1. Validated dsep.yaml with core-spec v1.1.0 & Made Fixes
  2. Validated the examples in the dsep domain repository against core-spec v1.1.0 ( for All Categories i.e courses, scholarship, work opportunities etc) and made fixes.
  3. Validated the examples used in the implementation guide against core-spec v1.1.0 and made fixes.

Analysis of DSEP Examples against core V1.1.0

1. Course

  1. on_cancel - item.quantity, billing, fulfillment.customer.person.cred- schema issue
  2. Rating - schema issue
  3. on_select - item.quantity schema issue
  4. Support - schema issue [Fix not required]
  5. on_update - item.quantity schema issue

2. Expert Connect

  1. Everywhere version should be V1.1.0 in the context.version
  2. Fulfillment scheme issue
  3. Complete on_search schema need fix
  4. Select - ProviderID, fulfillment id is not selected
  5. OnSelect - Schema issue
  6. Init/confirm - billing - schema issue
  7. on_init - Schema issue
  8. On_confirm - Schema issue
  9. on_cancel - Schema issue
  10. Rating - Schema Issue
  11. On_status - Schema issue
  12. Support & on_support Schema Issue [Fix not required]

  13. on_update - Schema issue

    3. Financial Support (0.7.0)

  14. on_init : message.order.payments[0].params.bank_account_name is not available in core-v1.1.0 [Fix not required]
  15. on_init: message.order.items.xinput - schema has some attributes which are not available in core-v1.1.0 [Fix not required]
  16. Confirm : message.order.fulfillments[0].customer.id is not available in core-v1.1.0 [Fix not required]
  17. on_confirm - message.order.docs is not present in core-v1.1.0 [Fix not required].
  18. Rating - schema is wrong

  19. Support & on_support - has some new attributes in the schema [Fix not required].

    4. Student Connect

  20. Search-by-location - Incorrect Schema

  21. On_confirm - message.order.docs is not present in core-v1.1.0 [Fix not required].

    5. Work Opportunity

  22. Search - Intent - item should be an object
  23. On_search - empty payment object
  24. Rating - Schema issue
  25. Support & on_support - has some new attributes in the schema [Fix not required].

Note

  1. [Fix not required]. - It means some schema which were modified in dsep domain specs during ONEST go-live, but they are not present in core-v1.1.0. A draft release note is already created for core-v1.2.0 - https://github.com/beckn/protocol-specifications/releases/tag/untagged-e6435da5f188a45da8ff