beckn / PULSE-Specification

Adaptation of beckn protocol for online dispute resolution
Other
2 stars 9 forks source link

Validating PULSE Specification against the Beckn Core specification v 1.1.0, validating examples against the updated PULSE specification #25

Open rajaneeshk90 opened 5 months ago

rajaneeshk90 commented 5 months ago

Problem: The example JSON are not consistent with the specification. For instance:

The details of the issue can be found in this issue page: https://github.com/beckn/PULSE-Specification/issues/24

Changes made:

Related ticket: https://github.com/beckn/beckn-ui-workspace/issues/483

emmayank commented 5 months ago

HI @rajaneeshk90 ,

I have reviewed your PR. please find the observations below and make the necessary change.

  1. /Init ( example) - message.item[0].xinput - Schema is incorrect
  2. /confirm ( example) - message.item[0].xinput - Schema is incorrect
  3. /rating (example) - rating value is missing
  4. /support (example) - support schema is incorrect
  5. /on_rating(example) - schema is incorrect
  6. /on_support(example) - schema is incorrect

Thanks @emmayank

rajaneeshk90 commented 5 months ago

Hi @emmayank

Thanks for reviewing the PR. I have made the suggested changes, please have a look.