search

beckn / Unified-Energy-Interface

Adaptation of beckn protocol for energy sector
Other
21 stars 14 forks source link

Incorrect usage of "city" field in UEI example JSON context #17

Open rajaneeshk90 opened 7 months ago

rajaneeshk90 commented 7 months ago

Issue Details:

Problem Statement:

All the json examples in UEI repo are using the city field inside the context incorrectly.

The "city" field should be inside the "context.location" object but instead city is placed in the "context" directly.

One incorrect use can be found on the UEI github repository: https://github.com/beckn/Unified-Energy-Interface/blob/main/examples/ev-charging/search/search-request.json#L11

example:

`"context": {
    "domain": "dent:0.1.0",
    "action": "search",
    "location": {
      "country": {
        "name": "India",
        "code": "IND"
      }
    },
    "city": "std:080",
    "version": "1.1.0",
    "bap_id": "example-bap.com",
    "bap_uri": "https://api.example-bap.com/pilot/bap/energy/v1",
    "transaction_id": "6743e9e2-4fb5-487c-92b7-13ba8018f176",
    "message_id": "6743e9e2-4fb5-487c-92b7-13ba8018f176",
    "timestamp": "2023-07-16T04:41:16Z"
  }`

It is essential to investigate the incorrect use of city field in the context object and rectify it.