Closed vbabuEM closed 1 month ago
Related to #210
I connected with @vbabuEM and discussed the approach I was following. He approved it but mentioned that we need to make additional changes to the shell script.
I’ve made the necessary changes to the script for the Layer2 configuration during the BAP installation. Below are the screenshots showing the test cases:
Screenshot with correct Layer2 Configuration URL:
Screenshot showing the error when the Layer2 Configuration URL is incorrect or the download fails:
Screenshot if the user skips entering the Layer2 Configuration URL:
I will replicate the same for the BPP installation.
This sounds fine Prasad. Please go ahead. @prasad-takale-eminds
I’ve made the necessary changes to the script for the Layer2 configuration during the BPP installation. Below are the screenshots showing the test cases:
Screenshot with correct Layer2 Configuration URL:
Screenshot showing the error when the Layer2 Configuration URL is incorrect or the download fails:
Screenshot if the user skips entering the Layer2 Configuration URL:
PR for layer 2 config installation. https://github.com/beckn/beckn-onix/pull/227
Review Completed
Problem When Beckn-ONIX was first demonstrated, it had the following prompt:
"Paste the URL of the network configuration here (or press Enter to skip)"
At that time, this was not linked to anything and so on a review comment, we had removed this prompt.
Subsequently, now we mandatorily need layer 2 config for BAP and BPP. The behaviour of layer 2 for Registry and Gateway is still not defined. So we can re-add this prompt to the installation of BAP and BPP.
Solution