beckn / beckn-sandbox

MIT License
2 stars 2 forks source link

bpp_id and bpp_uri are hardcoded #12

Open vbabuEM opened 2 months ago

vbabuEM commented 2 months ago

In the response that is sent, the bpp_id and bpp_uri are hardcoded to the following:

"bpp_id": "sandbox-bpp-network.becknprotocol.io",
"bpp_uri": "https://sandbox-bpp-network.becknprotocol.io",

When we deploy on different networks, this is misleading. Make the bpp_id and bpp_uri as configurable in the .env file.

This is a problem primarily in the search request as bpp_id and bpp_uri are not there in the header of the request.

For the rest of the requests, it seems to be using the request parameters in the response and so it seems ok.