search

beckn / beckn-ui-workspace

Mono Repo for Beckn UI Workspace
9 stars 12 forks source link

In the ODR app, if the user does not fill in the "Dispute Details" field and tries to save, the app crashes. #2028

Open SanketEminds opened 1 month ago

SanketEminds commented 1 month ago

Bug Description

In the ODR app, if the user does not fill in the "Dispute Details" field and tries to save, the app crashes.

Steps to Reproduce

Open the ODR app. Navigate to the "Dispute Details" section. Leave the "Dispute Details" field empty. Attempt to save the form. Observe that the app crashes.

Expected Behavior

The app should prompt the user to fill in the "Dispute Details" field before saving or display an error message instead of crashing.

Actual Behavior

The app crashes when the "Dispute Details" field is left empty, and the user tries to save.

Figma

(Include Figma link or relevant details here)

Environment

Prod, Staging, Dev

Screenshots/Logs

Image

skrushna1506 commented 1 month ago

@aniketceminds As we received the dispute details form from the X-input, there is no validation in place. This allows the user to randomly click the submit button, resulting in the API not receiving the payload. Consequently, the submit API fails, causing the API to crash.

for this we need to add validation on x-input form CC:- @omkar-em @viraj89 @emmayank

Image

skrushna1506 commented 1 month ago

PR for above task https://github.com/beckn/beckn-ui-workspace/pull/2091 CC:- @aniketceminds @emmayank @PritiEM @omkar-em also Screenshot for same

Image

omkar-em commented 1 month ago

@skrushna1506 @rahul-eminds As shown in the Figma design, the claim value field is optional. Please find the attached SS. Image

cc- @emmayank @PritiEM

omkar-em commented 1 month ago

@skrushna1506 can you check previous comment?

omkar-em commented 2 weeks ago

Working Fine cc- @emmayank @PritiEM