search

beckn / beckn-ui-workspace

Mono Repo for Beckn UI Workspace
9 stars 13 forks source link

BAP - In BAP side /trade API, user is able to provide negative price and quantity #2345

Open omkar-em opened 1 month ago

omkar-em commented 1 month ago

Bug Description

The /trade API on the BAP side allows users to submit a negative price when creating a trade. This can lead to invalid transactions and disrupt the intended functionality of the trading process.

Steps to Reproduce

  1. Make a request to the /trade API with a negative price value.
  2. Submit the trade request.
  3. Observe that the API processes the request successfully, allowing a trade with a negative price.

Expected Behavior

The /trade API should validate the price input and reject any requests containing negative prices, ensuring that only valid price values are accepted.

Actual Behavior

The API accepts negative prices without any validation errors, allowing invalid trades to be processed.

Figma

NA

Environment

Screenshots/Logs

Image

shreyvishal commented 3 weeks ago

Current Status: Done with development, deployment and testing

Code Link - Link

Postman Collection Beckn One.postman_collection.json