search

beckn / beckn-ui-workspace

Mono Repo for Beckn UI Workspace
9 stars 13 forks source link

Validating DHP Specification with Core v 1.1.0 #481

Open emmayank opened 7 months ago

emmayank commented 7 months ago

Description

Validate the dhp.yaml file with the core-spec v1.1.0 version. Also, validate the examples JSON files given in the example directory and in the implementation guide against core-spec v1.1.0.

Goals

Sub Tasks

a. Validate dhp.yaml with core-spec v1.1.0. b. Validate the examples in the mobility domain repository against core-spec v1.1.0. c. Validate the examples used in the implementation guide against core-spec v1.1.0.

Expected Outcome

The dhp.yaml file, examples in the dhp domain repository, and examples used in the implementation guide should pass validation against core-spec v1.1.0.

Acceptance Criteria

Product Name

Beckn

Domain

DHP

Tech Skills Needed

Spec validation tools, YAML, JSON

Complexity

Medium

Category

Validation

Sub Category

Spec Compliance

emmayank commented 7 months ago

[3rd April, 2024] Time Spent : 5.5 hrs

1. Ambulance ( 2hrs)

  1. Search-request-start-location-vehicle-patient-type.json, Search-request-start-location-vehicle-type.json, Search-request-start-location.json - Invalid location schema
  2. On_init - payments schema is invalid
  3. On_confirm, on_cancel, on_status, on_update - fullfilment.stop[0]- invalid schema
  4. Support & on_support - has some new attribute in the schema [Fix not required].

2. Blood-bank ( 1hrs)

  1. All search request - message.intent.item.quantity - Invalid schema
  2. search-request-emergency-blood-bank-location.json, Search-request-emergency-blood-location.json - message.intent.fulfilment.stop[0].location - Invalid Schema
  3. On_cancel - invalid action value
  4. Support & on_support - has some new attribute in the schema [Fix not required].
  5. Update - context schema is invalid

3. Consultation ( 2hrs)

  1. All examples - context schema is invalid
  2. search-category-location-item-provider.json, Search-category-location-item.json, Search-location-item.json- invalid schema
  3. on_init.json - message.order.item.Xinput - schema has some attributes which are not available in core-v1.1.0 [Fix not required].
  4. Confirm, on_confirm, on_init : message.order.payments[0].params.bank_account_name is not available in core-v1.1.0 [Fix not required].
  5. On_update, on_status, on_confirm, confirm - payment schema is invalid
  6. Rating schema is invalid
  7. Support & on_support - has some new attribute in the schema [Fix not required].

4. Diagnostics ( 15 min)

  1. All examples - context schema is invalid
  2. Search request - invalid location schema
  3. duplicate samples are available, need only one.

5. Pharmacy ( 15 min)

  1. All examples - context schema is invalid
  2. Search request - invalid location schema
  3. duplicate samples are available, need only one.

Note

  1. [Fix not required]. - It means some schema which were modified in dsep domain specs during ONEST go-live, but they are not present in core-v1.1.0. A draft release note is already created for core-v1.2.0 - https://github.com/beckn/protocol-specifications/releases/tag/untagged-e6435da5f188a45da8ff
emmayank commented 7 months ago

[10th April, 2024] Time Spent : 6 hrs

  1. Ambulance example issue fixed
  2. Blood-bank example issue fixed
  3. Consultation example issue fixed
  4. Diagnostics example issue fixed
emmayank commented 7 months ago

[10th April, 2024] Time Spent : 5.5 hrs

  1. Pharmacy example issue fixed
  2. Updated Implementation Guide for Pharmacy, Diagnostics & Consultation
  3. Validate dhp.yaml with core-spec v1.1.0.
emmayank commented 7 months ago

The Ticket is Completed & PR is raised here - https://github.com/beckn/DHP-Specs/pull/116