search

beckn / missions

This repo is solely created for the project management of the fide missions. the repo will be utilised for documentation purposes.
MIT License
7 stars 1 forks source link

UEI Implementation Guide V1.2 Internal Review & Rework #163

Open yesrag2309 opened 2 weeks ago

yesrag2309 commented 2 weeks ago

Back Story

  1. UEI EV charging implementation guide V1.0 is created and Completed Implementations with 3 participants.
  2. Based on the NPs feedback Tech team is updating the guide V1.1
  3. Implementation Guide V1.1 & L2 config is updated and PR raised for Internal Review with @faizmagic 11th Nov

Nov11-Nov14 Plan

  1. Nov 11th Review with @faizmagic
  2. Post review call review comments need to incorporate and ready for V1.1 with Global Mission team

Reference Card

https://github.com/beckn/missions/issues/130 - Previous Iteration Closed Card

MD Link

MD link needs to be add once the PR is merged with main branch. Please find the PR link below

PR Link

yesrag2309 commented 2 weeks ago

Current Status

  1. UEI implementation guide review happened with @faizmagic for 45mins.
  2. Please find below the review comments.
    • Need to connect with Pooja to gather the standard "enums" details that is defined and agreed by NPs for tag codes
    • Standardize the tag codes for state of charge, energy delivered, current voltage, etc.

Next Steps

  1. Need to update the Guide 1.1 based on @faizmagic comments
  2. Additional NP point has to incorporate in the guide under V 1.2 by next week.
    • For reference additional points details, An additional point was raised regarding charging options. Some NPs prefer time-based charging, while others prefer energy unit-based or money-based charging. We should add examples demonstrating each of these options

@rajaneeshk90

yesrag2309 commented 2 weeks ago

NPs Feedback/Changes [Incorporated into the implementation guide Ver1.2]

  1. Charging Point Details: Add charging point details in the catalog. Information related to charging connectors already exists, and this should be added to the fulfillments object.

  2. Charging Station Details: Add charging station information to the catalog. (A charging station can have multiple charging points, and each charging point can have multiple connectors.) This should be included in the provider description and location sections.

  3. Quotation Object: Remove the quotation object from the confirm API payload. Update the quotation object in the on_select, on_init, on_confirm etc.

  4. Current Charging Details: Add details related to the current charging status—such as state of charge, energy delivered, current voltage, etc.—in the on_status payload. This should be included within the fulfillments tags.

Internal Review Comments

  1. L2 cofig file make it as strict that NPs couldn't customize
  2. The tag descriptions for UEI should be included in the implementation guide, with each tag defined by SN, name, code, meaning, and usage. This table will evolve based on NP inputs.

Current Status

  1. Based on @faizmagic suggestion on L2 Config @rajaneeshk90 is working on the L2 config file make it as strict that NPs couldn't customize. ETA 18th Nov.
  2. Based on @faizmagic review on 12th November. The tag descriptions for UEI should be included in the implementation guide, with each tag defined by SN, name, code, meaning, and usage. This table will evolve based on NP inputs.
  3. The above mentioned NPs suggested feedback/changes are updated and it will be published as Ver1.2 along with the preparing L2 config file ETA 18th November

Next Steps

Version 1.2

  1. The above mentioned @faizmagic review comments to be update and it will be published as Ver1.1 along with the L2 config file ETA 18th November

Version 1.3

  1. Additional NP point has to incorporate in the guide under V 1.3 by 22nd Nov
    • For reference additional points details, An additional point was raised regarding charging options. Some NPs prefer time-based charging, while others prefer energy unit-based or money-based charging. We should add examples demonstrating each of these options
  2. We need to merge the Fulfillment Objects Connector Spec and Charging Point Spec. The tech team will have a call with the NPs and @poojamanjooran to explain that this approach is better. If the NPs agree, the changes will be implemented, and we will publish version 1.3 on 22nd Nov
yesrag2309 commented 2 weeks ago

Current Status

Version 1.2 - ETA 18th Nov

  1. @rajaneeshk90 has completed the L2 configuration file, setting it to be strict, which prevents NPs from customizing it.
  2. We had a check-in call with NPs.
  3. Following today’s NPs check-in call, tag descriptions are being prepared by NPs, with each tag defined by SN, name, code, meaning, and usage. Once finalized, @rajaneeshk90 will incorporate these into the implementation guide as a table. This table will be dynamic, allowing NPs to update it as tags are added or modified.

Version 1.3 - ETA 22nd Nov

  1. We had a check-in call with NPs.
  2. Following today’s NP check-in call, @rajaneeshk90 will share an example JSON demonstrating the merging of the Fulfillment Objects Connector Spec and Charging Point Spec in the Discord channel. NPs can review this example, and once it is reviewed and approved, it will be included in the guide as part of version V1.3.

Next Steps

Version 1.2 - ETA 18th Nov

  1. Following today’s NP check-in call, tag descriptions are being prepared by NPs, with each tag defined by SN, name, code, meaning, and usage. Once finalized, @rajaneeshk90 will incorporate these into the implementation guide as a table. This table will be dynamic, allowing NPs to update it as tags are added or modified.

Version 1.3 - ETA 22nd Nov

  1. Additional NP point has to incorporate in the guide under V 1.3 by 22nd Nov
    • For reference additional points details, An additional point was raised regarding charging options. Some NPs prefer time-based charging, while others prefer energy unit-based or money-based charging. We should add examples demonstrating each of these options
  2. Following today’s NP check-in call, @rajaneeshk90 will share an example JSON demonstrating moving the Fulfillment Object Connector Specification from fulfillment array into items[idx] and share in the Discord channel. NPs can review this example, and once it is reviewed and approved, it will be included in the guide as part of version V1.3.

CC- @faizmagic @poojamanjooran @viraj89 @emmayank

yesrag2309 commented 2 weeks ago

Current Status

  1. Working on tag descriptions which is prepared by NPs, with each tag defined by SN, name, code, meaning, and usage. Incorporating these into the implementation guide as a table. This table will be dynamic, allowing NPs to update it as tags are added or modified.
  2. Working on the example JSON demonstrating moving the Fulfillment Object Connector Specification from fulfillment array into items[idx] and share in the Discord channel. NPs can review this example, and once it is reviewed and approved, it will be included in the guide as part of version V1.3
  3. Working on add meta APIs (e.g., get_rating_categories) and other relevant details in the implementation guide.

Next Steps

Version 1.3 - ETA 22nd Nov

  1. Additional NP point has to incorporate in the guide under V 1.3 by 22nd Nov

    • For reference additional points details, An additional point was raised regarding charging options. Some NPs prefer time-based charging, while others prefer energy unit-based or money-based charging. We should add examples demonstrating each of these options.

    CC- @faizmagic @poojamanjooran @viraj89 @emmayank

rajaneeshk90 commented 2 weeks ago

Current Status:

  1. Tag codes and enum values provided by NPs are added in the implementation guide. reference for tag coeds: https://www.notion.so/UEI-Payloads-and-Enums-13dcc6816c1e806aa396c67b22715753?pvs=25#13dcc6816c1e8048ab76f65aa5035af9
  2. Created a sample example JSON moving the Fulfillment Object Connector Specification from fulfillment array into items[idx] and share in the Discord channel.
  3. Added meta APIs (e.g., get_rating_categories) and other relevant details in the implementation guide.

Next Steps:

  1. for the sample example json shared in the discord channel, based on NPs agreement, will make the change in imp guide.
yesrag2309 commented 1 week ago

Current Status:

Tag codes and enum values provided by NPs are added in the implementation guide. reference for tag coeds: https://www.notion.so/UEI-Payloads-and-Enums-13dcc6816c1e806aa396c67b22715753?pvs=25#13dcc6816c1e8048ab76f65aa5035af9 Created a sample example JSON moving the Fulfillment Object Connector Specification from fulfillment array into items[idx] and share in the Discord channel. Added meta APIs (e.g., get_rating_categories) and other relevant details in the implementation guide.

Next Steps:

for the sample example json shared in the discord channel, based on NPs agreement, will make the change in imp guide.

yesrag2309 commented 1 week ago

Current Status:

Tag codes and enum values provided by NPs are added in the implementation guide. reference for tag coeds: https://www.notion.so/UEI-Payloads-and-Enums-13dcc6816c1e806aa396c67b22715753?pvs=25#13dcc6816c1e8048ab76f65aa5035af9 Created a sample example JSON moving the Fulfillment Object Connector Specification from fulfillment array into items[idx] and share in the Discord channel. Added meta APIs (e.g., get_rating_categories) and other relevant details in the implementation guide.

Next Steps:

for the sample example json shared in the discord channel, based on NPs agreement, will make the change in imp guide.

rajaneeshk90 commented 1 week ago

Pending items:

  1. Help ChargePE with the implementation.
  2. get an update on the proposed change to move connector specification taggroups from fulfillments to items
  3. add time-based charging, energy unit-based and money-based charging flows in the implementation guide.
yesrag2309 commented 5 days ago

The following pending items will be tracked under a new flow card for the next iteration (Nov 24 - Dec 8). Items 2 and 3 will be included in the implementation guide as part of V1.1:

Hence closig this card

Pending items:

  1. Help ChargePE with the implementation.
  2. Get an update on the proposed change to move connector specification taggroups from fulfillments to items
  3. Add time-based charging, energy unit-based and money-based charging flows in the implementation guide.

@faizmagic @rajaneeshk90 @viraj89 @emmayank