basileLeroy
commented
10 months ago Feedback version 2 (my bad)
I'll start by suggesting to not upload a folder in a repository, but instead the content of the folder (make sure your .git folder is inside the project folder) That way, it will be easier to avoid me missing the content of the repository 😅 .
So! After a look at your index.php, I will say good work! I have a couple of remarks but they are minor (one bigger one)
big remark: Make sure to put your php logic at the top of your file, the rule of thumb is to load the logic before loading the html, since the html might need information from the logic.
smaller remarks: Using a switch would maybe be a little more recommended. in case you would upgrade your project and have multiple choices in both currencies (cur1 and cur2).
Try to use full names, instead of curr1 and curr2, use terms that could be more descriptive: $currencyFrom and $currencyTo
That's it! well done.
Feedback
I could not see any results.
Make sure to commit your work every time you make a project or exercise!