search

becvert / cordova-plugin-zeroconf

Cordova ZeroConf Plugin
MIT License
81 stars 57 forks source link

Could you add a 'fail' property on the ZeroConf interface. #15

Closed NeoLSN closed 7 years ago

NeoLSN commented 7 years ago

Currently, I want to send an error event when the ZeroConf is down, but there is no interface let me put or replace the failure function. I can only see the error happen on the console but nothing I can do. So could you please add a fail property like cambiocreative do?

NeoLSN commented 7 years ago

I also suggest ionic-native should support your plugin. See https://github.com/driftyco/ionic-native/issues/636. So it might needs your plugin provide success and fail callback on the interface.

becvert commented 7 years ago

That sounds good. I'll do that. Thanks

becvert commented 7 years ago

Master branch's been updated. Please tell me if that's fine with you.

NeoLSN commented 7 years ago

Great job. Just waiting for new release.

NeoLSN commented 7 years ago

Will you release 1.2.0 to npm?

becvert commented 7 years ago

Yes I will. I'd like to release it this week. I made some other improvements that I want to test properly before. Plus I'm just caught up in some other stuff right now.

becvert commented 7 years ago

done