[iOS] Crash, if service txtRecordData is malformed

[fishkingsin]

I have a device broadcasting null value dictionary cause crashed in https://github.com/becvert/cordova-plugin-zeroconf/blob/master/src/ios/ZeroConf.swift#L354

[becvert]

ok. does it work on Android?

[fishkingsin]

it is ios specific issue have not tried on android

[becvert]

Please test version 2.1.4

[fishkingsin]

I found that in txtRecordData is raw byte data to translate it to dictionary it need a proper key,value pair format

but some of my device boardcasted

Optional("\u{0E}isPaired=false\u{0C}serialNumber\rmodel=MODEL_NAME")

serialNumber(key) was wrong format "=" is missing "value" is missing

[becvert]

so txtRecordData returns some data but it is malformed key/value pairs?

are you able to do a quick check on android too? that would be nice.

[becvert]

Does it still crash the app by the way?

[fishkingsin]

it will crash seem NSDictionary could not parse the malformed data

[becvert]

NetService.dictionary fails an assertion if txtData cannot be represented as an NSDictionary object

failed assertions terminate the app in debug for sure, but maybe not in production. @fishkingsin , does it crash in production?

if it does, the problem is in Swift you cannot catch a failed assertion. that means we need to parse ourselves the data. I do not want to do that.

[fishkingsin]

@becvert thanks for the comment, I will trying to fix that

[becvert]

What's the status on this @fishkingsin

[fishkingsin]

I think it only happen from my case, ios + melform txtData I have no idea how to fix that

[becvert]

No worries. I'll have another look later on.

[fishkingsin]

some finding https://stackoverflow.com/questions/40193911/nsnetservice-dictionaryfromtxtrecord-fails-an- assertion-on-invalid-input

[certabitmh]

any news on that?

[becvert]

Nope. Closing old issue. Feel free to reopen.