search

becvert / cordova-plugin-zeroconf

Cordova ZeroConf Plugin
MIT License
81 stars 57 forks source link

[iOS] zeroconf.close never invokes success/error callback #52

Closed antweb closed 6 years ago

antweb commented 6 years ago

The behaviour of zeroconf.close() is inconsistent between Android and iOS. While Android sends a plugin result, iOS does not. As the Android version uses a background thread, it is necessary to rely on the callback to make sure the action has finished.

A simple solution would be to send a success plugin result in iOS as well.

becvert commented 6 years ago

ok I'll have a look sometime. thank you

emcniece commented 6 years ago

@becvert I can PR today!

becvert commented 6 years ago

53 is fixing the close method actually.

I think the same could be apply to stop indeed @emcniece go ahead with merging this into 1.3.0. thanks 👍