search

becvert / cordova-plugin-zeroconf

Cordova ZeroConf Plugin
MIT License
81 stars 57 forks source link

chore(deps): use caret semver #80

Closed qkdreyer closed 4 years ago

qkdreyer commented 5 years ago

https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004

emcniece commented 4 years ago

Thank you for the PR (and that beautiful clog syntax)!

I'm on the fence about this - we don't have automated testing, and the cordova-plugin-add-swift-support is critical to the functionality of this plugin. Right now we manually test each version bump before incrementing it.

In theory we are able to use range specification to limit how far the dependency will move, but we've had issues with this library in the past, even with patch-level increments.

We might be able to write some tests and run them in CI, but I'm not sure how easy it will be to get a reliable integration environment. This would have to be built & executed in iOS simulator in order to test, right? I don't know of any CI platforms that provide free iOS testing, though I haven't shopped for this in a long while. Either way, implementing testing is a worthy goal but a non-zero amount of work.

On the other hand, we could just open up the version window and fix bugs when they happen. "Agile" I think it's called.

@becvert do you have any preferences?

emcniece commented 4 years ago

Opting to merge. The maintainers of this repo are fairly busy, so perhaps it's better to allow for version increments via caret to avoid more effort.