Open phatpaul opened 3 years ago
👋 Hi, thanks for the PR!
I noticed that cordova-plugin-add-swift-support
has been removed. Is that safe to do for all platforms and supported versions? There's a description of what this plugin does over here - is this support provided somewhere else?
Sorry I didn't mean to update this PR with that change. I'll try to fix this PR so it doesn't include it.
Anyway, that plugin cordova-plugin-add-swift-support breaks my build on Android, so I removed it. I assumed that the swift support must have been integrated into cordova core by now. No? I'm about to test it on iOS...
EDIT: this PR https://github.com/akofman/cordova-plugin-add-swift-support/pull/78 to the swift pluigin would fix my Android problems, but the maintainer hasn't merged any PRs in 4 years. FYI: https://github.com/akofman/cordova-plugin-add-swift-support/issues/76
I added type defs for static code checking in vscode.
I'm not sure how to tell it that it clobbers cordova.plugins.zeroconf, so I had to add this to my code: