search

beda-software / drf-writable-nested

Writable nested model serializer for Django REST Framework
Other
1.07k stars 115 forks source link

Known problems with solutions in README file modified with a fix for … #148

Closed xalien10 closed 2 years ago

xalien10 commented 3 years ago

Known problems with solutions in README file modified with a fix for formdata update of nested fields via PUT or PATCH request

ir4y commented 3 years ago

Thank you for your contribution @xalien10 There are two small notes.

  1. Could you please leave the only minimum necessary set of fields in the example? There are a lot of fields that don't need to represent the issue and it confuses.
  2. Could you please provide an example of a working serializer or at least some part of it? You describe the technique, it is cool and should be in the README, but also it would be nice to provide more context where this code and be user, what serializer's controller's methods need to be override?
xalien10 commented 3 years ago

@ir4y I'll do that. Thank you for your feedback

codecov-commenter commented 3 years ago

Codecov Report

Merging #148 (ba5a629) into master (c6c47e4) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ba5a629 differs from pull request most recent head 10b4e02. Consider uploading reports for the commit 10b4e02 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files           3        3           
  Lines         220      220           
=======================================
  Hits          216      216           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c6c47e4...10b4e02. Read the comment docs.

xalien10 commented 3 years ago

@ir4y I've updated the PR with more concrete example. Please take a look when you have some time for it.

ir4y commented 3 years ago

@xalien10 Sorry for the long reply. It seems that everything is almost done. May I kindly ask you to add a test that demonstrates this behavior? I think it will provide an even better experience than just a code snippet.

ir4y commented 2 years ago

Ok, I am merging the documentation. If somebody face some issue with examples we will revisit the topic about tests. Thank you @xalien10

xalien10 commented 2 years ago

@ir4y I'm extremely sorry that I couldn't reply you back. Currently, I'm loaded heavily so couldn't write appropriate tests for the solution. If I can manage some time I'll definitely make a PR on that including the tests you asked for.

auvipy commented 2 years ago

@ir4y I'm extremely sorry that I couldn't reply you back. Currently, I'm loaded heavily so couldn't write appropriate tests for the solution. If I can manage some time I'll definitely make a PR on that including the tests you asked for.

good job bro