search

bedapisl / fast-colorthief

Selection of most dominant colors in image using Modified Median Cut Quantization
45 stars 1 forks source link

dependabot: add auto updating submodules #14

Closed baseplate-admin closed 10 months ago

baseplate-admin commented 11 months ago

Hi,

Is there something i needed to add?

For the PR to get merged?

bedapisl commented 10 months ago

I would like to hear some reasoning why this should be added, why do you want these changes merged.

Also I am not a fan of automated pull requests, which would be added by your MR. I am not saying I will never allow anything like that, but I don't see a reason for it right now.

baseplate-admin commented 10 months ago

Alright, Lemme start by saying, i am sorry i didnot communicate clearly.

Here's my reasoning behind the chagne:

  1. dependabot automatically updates submodules. We can add tests to our current module and see if anything breaks against new versions of pybind11.
  2. pybind11 has a lot of improvements compared to the version the project is using.
  3. Would make life easier if we use github actions to automate publishing against new versions of python ( you dont have to do manual compilations of files and such )

Thank you for the project :) it is far faster

bedapisl commented 10 months ago

Ok, maybe this is a good idea, I can try this. I will merge your MR and see how it will work. If it will be causing some problems, I can always remove it.

baseplate-admin commented 10 months ago

Thank you :D

baseplate-admin commented 10 months ago

Hey maybe we should change the frequency from daily to monthly

https://github.com/bedapisl/fast-colorthief/blob/b7899343e7c51bb556f17a4868e5d85be4f3c95d/.github/dependabot.yml#L12 https://github.com/bedapisl/fast-colorthief/blob/b7899343e7c51bb556f17a4868e5d85be4f3c95d/.github/dependabot.yml#L18