search

bedapub / designit

Blocking and randomization for experimental design
https://bedapub.github.io/designit/
Other
7 stars 1 forks source link

Try removing OSAT Remote #13

Closed banfai closed 1 year ago

banfai commented 1 year ago

Link #11

idavydov commented 1 year ago

Did I get it correctly?

This removes Remotes path of the OSAT package, meaning that it will be not installed in CI. And this will lead to an empty vignette.

Is that right, @banfai?

banfai commented 1 year ago

Did I get it correctly?

This removes Remotes path of the OSAT package, meaning that it will be not installed in CI. And this will lead to an empty vignette.

Is that right, @banfai?

No, this way it is installed. Apparently for bioc packages the Remotes section is not needed? I've found contradiction information about this... We've also had some conversation about this with @klmr, concluding that remotes, pak, pkgdepends, gitcreds, etc are a mess at the moment. I still need to check if GRAN works like this. In the CI artifact https://github.com/bedapub/designit/suites/9820420276/artifacts/472816872 the vignette is rendered: dev/articles/osat.html

klmr commented 1 year ago

All that is required for Bioconductor dependencies is an (empty) biocViews section in DESCRIPTION.

idavydov commented 1 year ago

fixed in the main branch