search

bedapub / designit

Blocking and randomization for experimental design
https://bedapub.github.io/designit/
Other
7 stars 1 forks source link

Replace mk_plate_scoring_functions with plate agnostic scoring functions will not work in current setup #23

Closed julianesiebourg closed 4 months ago

julianesiebourg commented 1 year ago

in the current optimize_multi_plate_design function for each plate a plate specific scoring function is generated with mk_plate_scoring_function. For these scoring functions a plate specific distance matrix is pre-calculated that will be used every time the scoring is done. Such pre-calculation would not be possible if we want to use the scoring functions in a 'group_by' manner and apply them on the fly to a given subset (plate) of all samples.

julianesiebourg commented 1 year ago

@idavydov & @banfai Does this summarize what we discussed?

idavydov commented 1 year ago

thanks, @julianesiebourg . yes, perfect.

One thing we discussed @ingitwetrust , if a scoring function can cache all the necessary object on the first run or if it detects change in the bc$locations_df or the sample sheet.

idavydov commented 4 months ago

@ingitwetrust kindly volunteered to fix this via #47 as far as I understand.

so I'm closing this in favor of the new issue.