bedapub / designit

Blocking and randomization for experimental design
https://bedapub.github.io/designit/
Other
7 stars 1 forks source link

multiplate wrapper iterate only on current plate scores #32

Open julianesiebourg opened 10 months ago

julianesiebourg commented 10 months ago

line 49 and following

    for (curr_plate in plate_levels) {
      if (!quiet && length(plate_levels) > 1) cat(curr_plate, "... ")

      bc <- optimize_design(bc,
        scoring = scoring_funcs,              # TODO: Here we should just use the scores of the current plate
        max_iter = max_iter,
        quiet = TRUE,
        shuffle_proposal_func = mk_subgroup_shuffling_function(
          subgroup_vars = plate,
          restrain_on_subgroup_levels = curr_plate
        ),
        acceptance_func = accept_leftmost_improvement
      )
    }
julianesiebourg commented 10 months ago

maybe remove the unlist() from line 38 to get a list of lists and then extract the curr_plate for all factors.