bedapub / designit

Blocking and randomization for experimental design
https://bedapub.github.io/designit/
Other
7 stars 1 forks source link

Change caching to precompiled HTML #8

Closed banfai closed 1 year ago

banfai commented 1 year ago

Fixes #3

banfai commented 1 year ago

weird... the results of this is different from the current vignette: https://bedapub.github.io/designit/articles/invivo_study_design.html#cage-arrangement-in-rack and https://bedapub.github.io/designit/articles/invivo_study_design.html#individual-animals-in-cages vs the same in https://github.com/bedapub/designit/suites/9096990658/artifacts/421684661

also, most of the examples in https://bedapub.github.io/designit/articles/plate_scoring_examples.html but not all of them 🤯

idavydov commented 1 year ago

@banfai could be related to R version random generator?

Should I review?

banfai commented 1 year ago

@banfai could be related to R version random generator? R 3.6.0 was released in April 2019, I don't think we've compiled the previous vignettes that long ago 😄

Should I review? I suppose if we're OK with the differences then yes please.

~@julianesiebourg @ingitwetrust do you think it's concerning that the old vignettes are different from the new?~ (see https://github.com/bedapub/designit/pull/8#issuecomment-1302211969 ) Could you please also review? update: something has changed since the last rendering of the children, @ingitwetrust tried and the rerendering with the old caching yields the same results as the new caching (both are different from the old, but identical to each other)