bedatadriven / activityinfo-R

ActivityInfo R Language Client
https://www.activityinfo.org/support/docs/R/
17 stars 12 forks source link

Revert test fixes for AI-3786 #108

Closed jamiewhths closed 8 months ago

jamiewhths commented 8 months ago

Test fixes were a failure, as they will now also reorder column vectors for e.g. text columns, without reordering the other column vectors at the same time. Diffcult to change the "canonicalization" routine without a fair amount fo effort as its 1) recursive so you have no context at present of the parent, and 2) we would need to know when we have a set of vectors which all must be reordered together (like column vectors), and adjust the routine accordingly.

For now, I have instead disabled the attachment field test. We currently have unit tests which test explicitly for serialisation and back-compatibility, and I will ask Lefos to add an API test to cover this case which should be equaivalent to this test anyway.