search

bedatadriven / activityinfo-R

ActivityInfo R Language Client
https://www.activityinfo.org/support/docs/R/
17 stars 12 forks source link

Allow users to specify a custom record ID when using addRecord() #111

Closed jamiewhths closed 3 months ago

jamiewhths commented 8 months ago

From AI-3942 Resolved by commit: 2b4bcf6

nickdickinson commented 4 months ago

Noting that this implementation uses the getRecord API call to check if the recordId already exists. If tables are wide, I imagine it may be significantly more efficient to do a table query for the id column with a limit of 1 instead? This could be tested in the future. If that is desirable I can add an issue to the backlog.

akbertram commented 4 months ago

@nickdickinson Because of the way we implement queries, getRecord() will always be faster.