search

bedatadriven / activityinfo-R

ActivityInfo R Language Client
https://www.activityinfo.org/support/docs/R/
18 stars 12 forks source link

Update auth.R #27

Closed MatayoBweta closed 1 year ago

MatayoBweta commented 1 year ago

Add a field savePassword to the authentification method to ensure that there is possibility to authenticate without asking if we should save the password.

nickdickinson commented 1 year ago

Thanks for the request. We are taking note of the pull request and this feature to skip interactive messages. It could be useful to some users. However, we cannot pull this into the main branch. We will be adding a new development branch where pull requests may be made. For your information, we are currently updating the authentication to deprecate username/password basic authentication and adding the the safer token based authentication as the replacement (#22 ).

It would be more logical to have an unset argument saveCredentials that if it is set to TRUE then it would save the credentials to a file and if FALSE it would not, otherwise if missing it would default to the normal interactive approach that current users know.

nickdickinson commented 1 year ago

Opened #40 for this feature

MatayoBweta commented 1 year ago

Thanks a lot and we will wait for potential contributions.

nickdickinson commented 1 year ago

@MatayoBweta Please see #40 for a temporary workaround that should be available sometime end of this week or next week.