bedatadriven / activityinfo-R

ActivityInfo R Language Client
https://www.activityinfo.org/support/docs/R/
17 stars 12 forks source link

Credentials file location leaked into logs #45

Closed nickdickinson closed 1 year ago

nickdickinson commented 1 year ago

https://github.com/bedatadriven/activityinfo-R/blob/7111a4b0da6fc9d39f54fae3cec84b7166a9d7ec/R/auth.R#L55

I would like to propose we comment out or remove this line of code to prevent credentials path location leaking out unnecessarily in logs potentially generated in Github actions and such. While presumably anyone who has file access should have access, I'm not sure announcing the location every time is useful. Better to have this documented another way. Also I imagine that many users that are saving credentials to file instead of as an environment variable or secret are potentially less aware of security risks.

nickdickinson commented 1 year ago

Addressed in 4.30