Closed akbertram closed 1 year ago
@nickdickinson is there a way to get the checks running on pull requests?
It is possible to do. Right now it will for pull requests to only 'main' and 'master' but I believe if we remove that specification from tic.yml it will run on any pull request. Shall I do that?
Sounds good!
Great, I'll make the change to 4.32 so when we merge it to main in the next release it will start in earnest. For now, I've run a job manually against the importer-improvements branch.
Hi Alex, the workflow failed because of a warning about the parentIdColumn argument not being added to the Roxygen: https://github.com/bedatadriven/activityinfo-R/actions/runs/4032578835/jobs/6932550069
❯ checking Rd \usage sections ... WARNING Undocumented arguments in documentation object 'importTable' ‘parentIdColumn’
Base: 43.84% // Head: 41.15% // Decreases project coverage by -2.70%
:warning:
Coverage data is based on head (
73c2515
) compared to base (a92dcf6
). Patch coverage: 0.00% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi Alex, there is one conflicting file in this branch on line 88 in import.R:
<<<<<<< importer-improvements
paste(head(parentId[!validParentIds]), collapse = ", ")))
=======
paste(head(parentIds[!validParentIds]), collapse = ", ")))
>>>>>>> version-4.32
I've resolved the conflict and will proceed to merge after testing.
A number of small fixes and refactoring for the importer.