Closed akbertram closed 1 year ago
Patch coverage: 57.14
% and project coverage change: -0.21
:warning:
Comparison is base (
556deba
) 67.68% compared to head (036c0a9
) 67.48%.:exclamation: Current head 036c0a9 differs from pull request most recent head f85090b. Consider uploading reports for the commit f85090b to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks @akbertram ! Do we need some kind of pagination? I'll merge this shortly.
Thanks @akbertram ! Do we need some kind of pagination? I'll merge this shortly.
Pagination is not relevant here. This allows the R client to upload the data to import directly to Google Cloud Storage (limit 5 TiB). The file is then accessible to the import job which reads it from google storage.
For the regex, should you maybe add ^ and $ to make sure the appspot url is actually your instance? "www.activityinfo.org||appspot.com"
Do you want to add a test? Should the preproduction server also be added?
If it's hosted on appspot.com, then it's running on AppEngine, which is not possible for the self-managed version. The pre-prod environment also matches this pattern.
And is this supposed to be merged into the main branch or v4.33?
And is this supposed to be merged into the main branch or v4.33?
Sorry, should have been 4.33
This updates the importTable() and stageImport() functions to use a signed URL to upload the data to be imported directly to Google Cloud Storage. I have left this as an option because it many users in Syria, Iran, etc are blocked from accessing storage.googleapis.com directly because of sanctions. (Our users are UN agencies and NGOs who are not subject to these sanctions!)