search

bedatadriven / activityinfo-R

ActivityInfo R Language Client
https://www.activityinfo.org/support/docs/R/
17 stars 12 forks source link

getDatabases() should always return a tibble #83

Closed akbertram closed 1 year ago

akbertram commented 1 year ago

The list of databases can be perfectly represented as a data.frame. There is no reason to return a list.

@Ryo-N7 will this break anything for you?

Ryo-N7 commented 1 year ago

no, this shouldn't break anything for me!

nickdickinson commented 1 year ago

We could leave the asDf argument but change the default to TRUE so if it is breaking any existing script, it is easy to fix with asDf = FALSE.

Ryo-N7 commented 1 year ago

i can add that to both getDatabases() and getDatabaseUsers()

Ryo-N7 commented 1 year ago

yup done, don't have time to create tests today so i'll try to do that tomorrow